From f7cd9712241eb7484cb6e850a22af3e2f0cfc331 Mon Sep 17 00:00:00 2001
From: yuqing <yuqing@yongche.com>
Date: Wed, 15 Feb 2017 16:04:06 +0800
Subject: [PATCH] fastcommon_file_put_contents bug fixed

---
 php-fastcommon/fastcommon.c               |  2 +-
 php-fastcommon/test_file_put_contents.php | 42 ++++++++++++-----------
 2 files changed, 23 insertions(+), 21 deletions(-)

diff --git a/php-fastcommon/fastcommon.c b/php-fastcommon/fastcommon.c
index cfb7330..88bbce0 100644
--- a/php-fastcommon/fastcommon.c
+++ b/php-fastcommon/fastcommon.c
@@ -1267,7 +1267,7 @@ ZEND_FUNCTION(fastcommon_file_put_contents)
 
         args[0] = &zfilename;
         args[1] = zdata;
-        args[1] = &zflags;
+        args[2] = &zflags;
         args[3] = zcontext;
         result = zend_call_user_function_wrapper(EG(function_table), NULL,
                     file_put_contents_func, return_value, 4, args TSRMLS_CC);
diff --git a/php-fastcommon/test_file_put_contents.php b/php-fastcommon/test_file_put_contents.php
index 25e83a5..580d12c 100644
--- a/php-fastcommon/test_file_put_contents.php
+++ b/php-fastcommon/test_file_put_contents.php
@@ -1,19 +1,21 @@
 <?php
 
+define('TEST_FLAGS', FILE_APPEND);
+define('LOOP_COUNT', 102400);
 function test_fastcommon_file_put_contents()
 {
     $start = microtime(true);
-    for ($i=0; $i<102400; $i++)
+    for ($i=0; $i<LOOP_COUNT; $i++)
     {
-        fastcommon_file_put_contents("/tmp/test.log", "this is a test\n", FILE_APPEND);
-        fastcommon_file_put_contents("/tmp/test1.log", "this is a test11\n", FILE_APPEND);
-        fastcommon_file_put_contents("/tmp/test1.log", "this is a test12\n", FILE_APPEND);
-        fastcommon_file_put_contents("/tmp/test2.log", "this is a test21\n", FILE_APPEND);
-        fastcommon_file_put_contents("/tmp/test2.log", "this is a test22\n", FILE_APPEND);
-        fastcommon_file_put_contents("/tmp/test2.log", "this is a test23\n", FILE_APPEND);
-        fastcommon_file_put_contents("/tmp/test3.log", "this is a test31\n", FILE_APPEND);
-        fastcommon_file_put_contents("/tmp/test3.log", "this is a test32\n", FILE_APPEND);
-        fastcommon_file_put_contents("/tmp/test3.log", "this is a test33\n", FILE_APPEND);
+        fastcommon_file_put_contents("/tmp/test.log", "this is a test\n", TEST_FLAGS);
+        fastcommon_file_put_contents("/tmp/test1.log", "this is a test11\n", TEST_FLAGS);
+        fastcommon_file_put_contents("/tmp/test1.log", "this is a test12\n", TEST_FLAGS);
+        fastcommon_file_put_contents("/tmp/test2.log", "this is a test21\n", TEST_FLAGS);
+        fastcommon_file_put_contents("/tmp/test2.log", "this is a test22\n", TEST_FLAGS);
+        fastcommon_file_put_contents("/tmp/test2.log", "this is a test23\n", TEST_FLAGS);
+        fastcommon_file_put_contents("/tmp/test3.log", "this is a test31\n", TEST_FLAGS);
+        fastcommon_file_put_contents("/tmp/test3.log", "this is a test32\n", TEST_FLAGS);
+        fastcommon_file_put_contents("/tmp/test3.log", "this is a test33\n", TEST_FLAGS);
     }
 
     $end = microtime(true);
@@ -24,17 +26,17 @@ function test_fastcommon_file_put_contents()
 function test_file_put_contents()
 {
     $start = microtime(true);
-    for ($i=0; $i<102400; $i++)
+    for ($i=0; $i<LOOP_COUNT; $i++)
     {
-        file_put_contents("/tmp/test.log", "this is a test\n", FILE_APPEND);
-        file_put_contents("/tmp/test1.log", "this is a test11\n", FILE_APPEND);
-        file_put_contents("/tmp/test1.log", "this is a test12\n", FILE_APPEND);
-        file_put_contents("/tmp/test2.log", "this is a test21\n", FILE_APPEND);
-        file_put_contents("/tmp/test2.log", "this is a test22\n", FILE_APPEND);
-        file_put_contents("/tmp/test2.log", "this is a test23\n", FILE_APPEND);
-        file_put_contents("/tmp/test3.log", "this is a test31\n", FILE_APPEND);
-        file_put_contents("/tmp/test3.log", "this is a test32\n", FILE_APPEND);
-        file_put_contents("/tmp/test3.log", "this is a test33\n", FILE_APPEND);
+        file_put_contents("/tmp/test.log", "this is a test\n", TEST_FLAGS);
+        file_put_contents("/tmp/test1.log", "this is a test11\n", TEST_FLAGS);
+        file_put_contents("/tmp/test1.log", "this is a test12\n", TEST_FLAGS);
+        file_put_contents("/tmp/test2.log", "this is a test21\n", TEST_FLAGS);
+        file_put_contents("/tmp/test2.log", "this is a test22\n", TEST_FLAGS);
+        file_put_contents("/tmp/test2.log", "this is a test23\n", TEST_FLAGS);
+        file_put_contents("/tmp/test3.log", "this is a test31\n", TEST_FLAGS);
+        file_put_contents("/tmp/test3.log", "this is a test32\n", TEST_FLAGS);
+        file_put_contents("/tmp/test3.log", "this is a test33\n", TEST_FLAGS);
     }
 
     $end = microtime(true);